Hi everybody. A few weeks ago I opened a small PR on the PHP SDK repository: Add an Api Factory to make Api mocking easier by ecourtial · Pull Request #172 · prismicio-community/php-kit · GitHub but did not get any answer so far. Is this SDK still maintained ? Regards Eric

Hi Eric, Welcome to the Prismic community and thanks for adding this PR. In fact, we are planning to move this kit to the Prismic community Github organization , and we are actively looking for community code maintainers for this kit. In the meantime I will have a look at this PR and get back to y…

Thank you @Fares we are actively looking for community code maintainers for this kit. We may contribute as we are basing some of our projects on it. This is why I already made this small PR.

Hi @Fares Any news on this matter :slight_smile: ?

Hi, May I have some more input about the PR you have created? you are deprecating a method that you reuse later! Looking forward to your reply, Fares

Hi Of course. So the idea is in the first time to ask developers to use the new method in the factory. This method is just a bridge to the old one. The goals are: Long term goal (next major version of the SDK) To use the best practice to have a factory instead of a singleton mixing both instant…

Thanks, @eric.courtial for this extensive explanation, that makes total sense. As I have mentioned before we are planning to move this kit to the Prismic community organization to make it totally managed by the community (we need to update those kits before moving them). And for that, we are looki…

Yes I have interest to participate, to be one of the code maintainer of this kit.

Awesome, I will add you as a code maintainer once we move this kit to the Prismic community org.

And regarding the PR I have added the information you have provided, reviewed it, and I asked our dev team to have a final review and merge.

Are pull requests still considered?

Developing with Prismic

Topic		Replies	Views
Legacy Builder and PHP Developing with Prismic	1	239	October 20, 2023
Please stop refactoring your javascript APIs Developing with Prismic javascript	1	423	April 7, 2023
PHP-SDK Guzzle is running old version Developing with Prismic php	11	2480	March 3, 2021
New PHP integration, API Client and Template Website built with Mezzio Developing with Prismic php	1	866	June 19, 2020
Prismic team: Please don't let the Ruby gem die! Developing with Prismic ruby	1	972	October 23, 2020

Are pull requests still considered?

Related topics