Rename Page Type modal closes when you hit the SPACE key

The Issue

Earlier today, I jumped into SliceMachine (via Chrome) to rename some of my client's custom page types and a weird thing kept happening:

Whenever I opened the Rename modal and hit the Space key, the modal would automatically close and send me to the edit view for that page type (as if I had simply clicked on the page type). Then, when I opened the Rename modal from within the edit view for the page type, it worked as expected. I only screen recorded one instance of this, but it occurred for all four of the other page types I renamed. Every time, it was the Space key that caused the behavior, not any other A-Z character.

In order to rule out that particular repository as the issue, I hopped into another and attempted to rename a custom type. Unfortunately, I ran into the same issue. Here's a Jam recording of it.

Impacted Feature

This tiny bug chips away at the otherwise-speedy and intuitive feel of SliceMachine. I love SliceMachine, so this is bumming me out.

Annoyance Level (from :cockroach: to :cockroach: :cockroach: :cockroach:)

:cockroach: if you only have to change the name of one page type
:cockroach: :cockroach: if you're renaming three or more page types at a time

Steps to Reproduce

Open SliceMachine and try to rename a custom page type to something with a Space in it. Seems like this might be a focus / activeElement issue?

Thanks in advance for your help! :v:

@epedersen thanks for spotting this one, we didn't know about it!
We'll look at it and fix it.

1 Like

Happy to help! And thanks for the response :cowboy_hat_face:

1 Like